Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @igchor)

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @igchor)

a discussion (no related file):
pls add a sentence or two in docs

tests/inline_string/inline_string.cpp, line 249 at r2 (raw file):

	});
}

perhaps test the opposite - that we can store it on DRAM...?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukaszstolarczuk)

a discussion (no related file):

Done.

tests/inline_string/inline_string.cpp, line 249 at r2 (raw file):

Done.

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @igchor)

include/libpmemobj++/experimental/inline_string.hpp, line 33 at r3 (raw file):

 * keeps the data within the same allocation as inline_string itself.
 *
 * Unlike other containers, can be used on pmem and dram. Modifiers (like

it can be used...

include/libpmemobj++/experimental/inline_string.hpp, line 34 at r3 (raw file):

 *
 * Unlike other containers, can be used on pmem and dram. Modifiers (like
 * assign() can only be called if inline string is kept on pmem).

something's wrong with the closing parenthesis in this sentence.

include/libpmemobj++/experimental/inline_string.hpp, line 357 at r3 (raw file):

 *
 * @throw std::out_of_range if rhs is larger than capacity.
 * @throw pool_error is inline string is not on pmem.

is ... is (did you mean if ... is?)

tests/inline_string/inline_string.cpp, line 252 at r3 (raw file):

template <typename T>
void
test_dram(nvobj::pool<struct root<T>> &pop)

that's a bit unusual test, pls add some comment(s)

tests/inline_string/inline_string.cpp, line 270 at r3 (raw file):

		  nvobj::basic_string_view<T>(*dram_location));

	dram_location->~basic_inline_string();

did you mean ~string_type? (not sure if you can call it like this)

tests/inline_string/inline_string.cpp, line 275 at r3 (raw file):

	UT_ASSERT(dram_location->capacity() == string_size);
	UT_ASSERT(dram_location->size() == 0);

ASSERTeq

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @lukaszstolarczuk)

include/libpmemobj++/experimental/inline_string.hpp, line 33 at r3 (raw file):

Done.

include/libpmemobj++/experimental/inline_string.hpp, line 34 at r3 (raw file):

Done.

include/libpmemobj++/experimental/inline_string.hpp, line 357 at r3 (raw file):

Done.

tests/inline_string/inline_string.cpp, line 252 at r3 (raw file):

Done.

tests/inline_string/inline_string.cpp, line 270 at r3 (raw file):

Actually yes, done ;d

tests/inline_string/inline_string.cpp, line 275 at r3 (raw file):

Done.

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @igchor)

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @igchor)